Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Polish the docs #1619

Merged
merged 3 commits into from
Sep 22, 2023
Merged

[Docs] Polish the docs #1619

merged 3 commits into from
Sep 22, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Sep 22, 2023

Details on the issue fix or feature implementation

Run the new sections through Chat GPT 4 model to polish them off.

Contributes to #1558

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk
Copy link
Contributor Author

cc @peter-csala

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8241fc4) 84.63% compared to head (52e2c63) 84.63%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1619   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files         306      306           
  Lines        6820     6820           
  Branches     1044     1044           
=======================================
  Hits         5772     5772           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 84.63% <ø> (ø)
windows 84.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk changed the title [Docs] Polish the retry docs [Docs] Polish the docs Sep 22, 2023
docs/strategies/fallback.md Outdated Show resolved Hide resolved
docs/strategies/fallback.md Outdated Show resolved Hide resolved
docs/strategies/retry.md Outdated Show resolved Hide resolved
docs/strategies/retry.md Outdated Show resolved Hide resolved
@martintmk martintmk enabled auto-merge (squash) September 22, 2023 12:21
@martintmk martintmk merged commit d2f9750 into main Sep 22, 2023
14 checks passed
@martintmk martintmk deleted the mtomka/polish-docs branch September 22, 2023 12:51
@martincostello martincostello added the v8 Issues related to the new version 8 of the Polly library. label Sep 26, 2023
@martincostello martincostello added this to the v8.0.0 milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants