Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spell checker #1667

Merged
merged 21 commits into from
Oct 6, 2023
Merged

Add spell checker #1667

merged 21 commits into from
Oct 6, 2023

Conversation

martincostello
Copy link
Member

Add a spell checker for Markdown files.

Resolves #1639.

Add a spellchecker for Markdown files.
Resolves #1639.
@martincostello martincostello added enhancement documentation CI/build dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Sep 29, 2023
Add a wordlist of things to not mark as misspelled.
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (305e0c3) 84.63% compared to head (52e615b) 84.63%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1667   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files         306      306           
  Lines        6819     6819           
  Branches     1045     1045           
=======================================
  Hits         5771     5771           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 84.63% <ø> (ø)
windows 84.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...y.Core/Fallback/FallbackStrategyOptions.TResult.cs 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ignore the benchmark files.
Remove the HTML checking.
Restore the HTML filter.
Ignore doesn't seem to work, so just check the root, any README file, docs and .github.
@martincostello
Copy link
Member Author

I'll come back to this later. The process is working, but it's picking up a lot of false positives, like GitHub logins and .NET method names etc.

Add setting to see if that fixes issues with code in codefences being spell-checked.
Bump rojopolis/spellcheck-github-actions to v0.34.0.
- Fix a number of typos (or change wording to "fix" them).
- Add more things to the wordlist.
Try ignoring CHANGELOG from the spellchecker.
- Fix more typos.
- Add more words to the wordlist.
As ignoring a file doesn't seem to work, cherry-pick the files from the repo-root to ignore CHANGELOG.
Try another Markdown extension - maybe it will ignore inline codefences.
- Fix more typos.
- Update wordlist further.
Try ignoring text that's in a pair of backticks.
Fix context filter indentation.
- Wrap more words in backticks.
- Fix more typos.
- Extend wordlist further.
@martincostello
Copy link
Member Author

I've fixed (or "fixed") a bunch more errors so there's a lot fewer now.

Most of what's left are type names or GitHub user logins.

I might need to ignore a few more files rather than add everyone to the wordlist file, but ignoring files seems to be a bit of a faff: rojopolis/spellcheck-github-actions#176

Will come back to this again later.

Otherwise the spellcheck files due to all the technical terms and the GitHub logins in these two files.
- Wrap more words in backticks.
- Add more terms to the wordlist.
Reword the sentence to avoid needing to add a GitHub login to the wordlist file.
@martincostello martincostello marked this pull request as ready for review October 6, 2023 08:30
@martincostello martincostello enabled auto-merge (squash) October 6, 2023 08:31
@martincostello martincostello merged commit 3040bfa into main Oct 6, 2023
14 checks passed
@martincostello martincostello deleted the add-spellcheck branch October 6, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/build dependencies Pull requests that update a dependency file documentation enhancement github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce linting for the docs
2 participants