-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Small cleanup and improvements #1782
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -306,7 +306,8 @@ sequenceDiagram | |||||
|
||||||
## Anti-patterns | ||||||
|
||||||
Over the years, many developers have used Polly in various ways. Some of these recurring patterns may not be ideal. This section highlights the recommended practices and those to avoid. | ||||||
Over the years, many developers have used Polly in various ways. Some of these | ||||||
recurring patterns may not be ideal. The sections bellow highlights anti-patterns to avoid. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
### Using different sleep duration between retry attempts based on Circuit Breaker state | ||||||
|
||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -154,7 +154,8 @@ Here's a breakdown of the behavior when the callback produces either an `HttpSta | |||||
|
||||||
## Anti-patterns | ||||||
|
||||||
Over the years, many developers have used Polly in various ways. Some of these recurring patterns may not be ideal. This section highlights the recommended practices and ones to avoid. | ||||||
Over the years, many developers have used Polly in various ways. Some of these | ||||||
recurring patterns may not be ideal. The sections bellow highlights anti-patterns to avoid. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
### Using fallback to replace thrown exception | ||||||
|
||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -200,7 +200,8 @@ while (!cancellationToken.IsCancellationRequested) | |||||
|
||||||
## Anti-patterns | ||||||
|
||||||
Over the years, many developers have used Polly in various ways. Some of these recurring patterns may not be ideal. This section highlights the recommended practices and those to avoid. | ||||||
Over the years, many developers have used Polly in various ways. Some of these | ||||||
recurring patterns may not be ideal. The sections bellow highlights anti-patterns to avoid. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
### Overusing builder methods | ||||||
|
||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -127,6 +127,9 @@ sequenceDiagram | |||||
|
||||||
## Anti-patterns | ||||||
|
||||||
Over the years, many developers have used Polly in various ways. Some of these | ||||||
recurring patterns may not be ideal. The sections bellow highlights anti-patterns to avoid. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
### Ignoring Cancellation Token | ||||||
|
||||||
❌ DON'T | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.