Fix BreakDurationGenerator not being used #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the `breakDurationGenerator` parameter required so that no code forgets to pass it through.
Add an integration test for when `BreakDurationGenerator` is specified to guard against the issue reported by App-vNext#1850.
Running `dotnet test` in the root of the repo would generate an error from trying to run tests in the Snippets project. As this project doesn't actually have any tests in it, mark it as not a test project.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1852 +/- ##
=======================================
Coverage 84.58% 84.58%
=======================================
Files 308 308
Lines 6798 6799 +1
Branches 1049 1049
=======================================
+ Hits 5750 5751 +1
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martintmk
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
Resolves #1850.
Details on the issue fix or feature implementation
BreakDurationGeneratorto the controller.BreakDurationGeneratorisn't configured, the test fails.breakDurationGeneratorparameter required so that no code forgets to pass it through.BreakDurationGeneratoris specified to guard against the issue reported by BreakDurationGenerator not passed to CircuitStateController #1850.dotnet testin the root of the repo would generate an error from trying to run tests in the Snippets project. As this project doesn't actually have any tests in it, mark it as not a test project.