[DO NOT MERGE] To verfiy build for Simmy docs PR #1894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Polly.Core/PublicAPI.Unshipped.txt
peter-csala
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1894 +/- ##
=======================================
Coverage 84.66% 84.66%
=======================================
Files 309 309
Lines 6836 6836
Branches 1052 1052
=======================================
Hits 5788 5788
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peter-csala
commented
Jan 12, 2024
peter-csala
commented
Jan 12, 2024
peter-csala
commented
Jan 12, 2024
peter-csala
commented
Jan 12, 2024
peter-csala
commented
Jan 12, 2024
|
|
||
| ## Diagrams | ||
|
|
||
| ### Happy path sequence diagram |
There was a problem hiding this comment.
It might make sense to explain why fault injection did not happen.
Or rename the Happy path to No fault injected / No injection
peter-csala
commented
Jan 12, 2024
|
|
||
| ## Diagrams | ||
|
|
||
| ### Happy path sequence diagram |
There was a problem hiding this comment.
It might make sense to explain why fault injection did not happen.
peter-csala
commented
Jan 12, 2024
peter-csala
commented
Jan 12, 2024
peter-csala
commented
Jan 12, 2024
peter-csala
commented
Jan 12, 2024
|
Pushed changes to the original PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
#1883
Details on the issue fix or feature implementation
This PR is just a collection of fixing commits until I can collaborate on @vany0114's branch.
Confirm the following