Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simmy API review Part 2 - Prefer Chaos over Monkey #1913

Merged
Prev Previous commit
Next Next commit
Fix broken links in documentation comments
peter-csala committed Jan 22, 2024
commit 1de5a1263b1f72d9d34d87af04efe14a510eb043
4 changes: 2 additions & 2 deletions src/Polly.Core/Simmy/Fault/FaultGenerator.cs
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ namespace Polly.Simmy.Fault;
/// A generator for creating faults (exceptions) using registered delegate functions.
/// </summary>
/// <remarks>
/// An instance of this class can be assigned to the <see cref="FaultStrategyOptions.FaultGenerator"/> property.
/// An instance of this class can be assigned to the <see cref="ChaosFaultStrategyOptions.FaultGenerator"/> property.
/// </remarks>
public sealed class FaultGenerator
{
@@ -69,7 +69,7 @@ public FaultGenerator AddException<TException>(int weight = DefaultWeight)
}

/// <summary>
/// Provides an implicit conversion from <see cref="FaultGenerator"/> to a delegate compatible with <see cref="FaultStrategyOptions.FaultGenerator"/>.
/// Provides an implicit conversion from <see cref="FaultGenerator"/> to a delegate compatible with <see cref="ChaosFaultStrategyOptions.FaultGenerator"/>.
/// </summary>
/// <param name="generator">The instance of <see cref="FaultGenerator"/>.</param>
[EditorBrowsable(EditorBrowsableState.Never)]

Unchanged files with check annotations Beta

"Trimming",
"IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute' require dynamic access otherwise can break functionality when trimming application code",
Justification = "All options members preserved.")]
public static TBuilder AddChaosFault<TBuilder>(this TBuilder builder, ChaosFaultStrategyOptions options)

Check warning on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / publish-docs

Check warning on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / publish-docs

Check warning on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / publish-docs

Check warning on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / publish-docs

Check warning on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / publish-docs

Check failure on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / windows-latest

Check failure on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / windows-latest

Check failure on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / windows-latest

Check failure on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / windows-latest

Check failure on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / windows-latest

Check warning on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / code-ql (csharp)

Check warning on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / code-ql (csharp)

Check warning on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / code-ql (csharp)

Check warning on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / code-ql (csharp)

Check warning on line 42 in src/Polly.Core/Simmy/Fault/ChaosFaultPipelineBuilderExtensions.cs

GitHub Actions / code-ql (csharp)

where TBuilder : ResiliencePipelineBuilderBase
{
Guard.NotNull(builder);
static Polly.Simmy.ChaosBehaviorPipelineBuilderExtensions.AddChaosBehavior<TBuilder>(this TBuilder! builder, Polly.Simmy.Behavior.ChaosBehaviorStrategyOptions! options) -> TBuilder!
static Polly.Simmy.Fault.FaultGenerator.implicit operator System.Func<Polly.Simmy.Fault.FaultGeneratorArguments, System.Threading.Tasks.ValueTask<System.Exception?>>!(Polly.Simmy.Fault.FaultGenerator! generator) -> System.Func<Polly.Simmy.Fault.FaultGeneratorArguments, System.Threading.Tasks.ValueTask<System.Exception?>>!
static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, double injectionRate, System.Func<System.Exception?>! faultGenerator) -> TBuilder!
static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!

Check warning on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / publish-docs

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check warning on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / publish-docs

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check warning on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / publish-docs

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check warning on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / publish-docs

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check warning on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / publish-docs

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check failure on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / windows-latest

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check failure on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / windows-latest

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check failure on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / windows-latest

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check failure on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / windows-latest

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check failure on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / windows-latest

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check warning on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / code-ql (csharp)

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check warning on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / code-ql (csharp)

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check warning on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / code-ql (csharp)

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check warning on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / code-ql (csharp)

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check warning on line 113 in src/Polly.Core/PublicAPI.Unshipped.txt

GitHub Actions / code-ql (csharp)

Symbol 'static Polly.Simmy.ChaosFaultPipelineBuilderExtensions.AddChaosFault<TBuilder>(this TBuilder! builder, Polly.Simmy.Fault.FaultStrategyOptions! options) -> TBuilder!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)
static Polly.Simmy.LatencyPipelineBuilderExtensions.AddChaosLatency<TBuilder>(this TBuilder! builder, double injectionRate, System.TimeSpan latency) -> TBuilder!
static Polly.Simmy.LatencyPipelineBuilderExtensions.AddChaosLatency<TBuilder>(this TBuilder! builder, Polly.Simmy.Latency.LatencyStrategyOptions! options) -> TBuilder!
static Polly.Simmy.OutcomePipelineBuilderExtensions.AddChaosResult<TResult>(this Polly.ResiliencePipelineBuilder<TResult>! builder, double injectionRate, System.Func<TResult?>! resultGenerator) -> Polly.ResiliencePipelineBuilder<TResult>!