Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Apply chaos selectively #1923

Merged
merged 7 commits into from
Jan 25, 2024
Merged

[Docs] Apply chaos selectively #1923

merged 7 commits into from
Jan 25, 2024

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jan 25, 2024

Details on the issue fix or feature implementation

Add section about how to apply chaos selectively.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added this to the v8.3.0 milestone Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dcfc01) 84.79% compared to head (ce3c3e5) 84.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1923   +/-   ##
=======================================
  Coverage   84.79%   84.79%           
=======================================
  Files         312      312           
  Lines        6893     6893           
  Branches     1056     1056           
=======================================
  Hits         5845     5845           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.79% <ø> (?)
macos 84.79% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/wordlist.txt Outdated Show resolved Hide resolved
@martintmk martintmk enabled auto-merge (squash) January 25, 2024 16:57
@martintmk martintmk merged commit 7ad0806 into main Jan 25, 2024
14 checks passed
@martintmk martintmk deleted the mtomka/selective-chaos branch January 25, 2024 17:31
@peter-csala
Copy link
Contributor

peter-csala commented Jan 26, 2024

@martintmk Would it make sense to turn the IChaosManager to asynchronous?

public interface IChaosManager
{
    ValueTask<bool> IsChaosEnabled(ResilienceContext context);

    ValueTask<double> GetInjectionRate(ResilienceContext context);
}

@martintmk
Copy link
Contributor Author

@martintmk Would it make sense to turn the IChaosManager to asynchronous?

public interface IChaosManager
{
    ValueTask<bool> IsChaosEnabled(ResilienceContext context);

    ValueTask<double> GetInjectionRate(ResilienceContext context);
}

I did not use it because in the code samples there was no async at all. But it can make the second sample little cleaner. Let me try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants