Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SA1111/SA1513/SA1121/SA1110 #1939

Conversation

baranyaimate
Copy link
Contributor

The issue or feature being addressed

Contributes to #1290

Details on the issue fix or feature implementation

Fix SA1111/SA1513/SA1121/SA1110 warnings

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 75 lines in your changes are missing coverage. Please review.

Comparison is base (e5e1a2a) 84.82% compared to head (1dfc906) 85.88%.

Files Patch % Lines
src/Polly/Retry/AsyncRetryTResultSyntax.cs 19.04% 34 Missing ⚠️
src/Polly/Retry/RetryTResultSyntax.cs 6.66% 14 Missing ⚠️
src/Polly/Retry/AsyncRetrySyntax.cs 76.19% 10 Missing ⚠️
...cuitBreaker/AdvancedCircuitBreakerTResultSyntax.cs 0.00% 6 Missing ⚠️
...reaker/AsyncAdvancedCircuitBreakerTResultSyntax.cs 0.00% 6 Missing ⚠️
src/Polly/Fallback/AsyncFallbackSyntax.cs 71.42% 2 Missing ⚠️
src/Polly/Retry/RetrySyntax.cs 92.30% 1 Missing ⚠️
src/Polly/Wrap/AsyncPolicyWrap.cs 83.33% 1 Missing ⚠️
src/Polly/Wrap/PolicyWrap.cs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1939      +/-   ##
==========================================
+ Coverage   84.82%   85.88%   +1.05%     
==========================================
  Files         312      312              
  Lines        6895     6637     -258     
  Branches     1056     1056              
==========================================
- Hits         5849     5700     -149     
+ Misses        837      728     -109     
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 85.88% <63.23%> (+1.05%) ⬆️
windows 85.88% <63.23%> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello enabled auto-merge (squash) January 30, 2024 20:29
@martincostello martincostello added this to the v8.3.0 milestone Jan 30, 2024
@martincostello martincostello merged commit 47b2d24 into App-vNext:main Jan 30, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants