Xml documentation cleanup #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere is no parameter by that name"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2008 +/- ##
=======================================
Coverage 83.64% 83.64%
=======================================
Files 312 312
Lines 7105 7105
Branches 1054 1054
=======================================
Hits 5943 5943
Misses 789 789
Partials 373 373
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martincostello
approved these changes
Mar 5, 2024
| @@ -37,7 +37,7 @@ bool TryRemove<TPolicy>(TKey key, out TPolicy policy) | |||
| /// <param name="key">The key whose value is compared with comparisonPolicy, and possibly replaced.</param> | |||
| /// <param name="newPolicy">The policy that replaces the value for the specified <paramref name="key"/>, if the comparison results in equality.</param> | |||
| /// <param name="comparisonPolicy">The policy that is compared to the existing policy at the specified key.</param> | |||
| /// <returns></returns> | |||
| /// <returns>True if the policy is successfully updated. Otherwise false.</returns> | |||
There was a problem hiding this comment.
Could use langword for these like we do for null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
Contributes to #1290 by further addressing some XML documentation quality issues as noted in #2007
Details on the issue fix or feature implementation
Pollyproject, so we get documentation related compiler warnings.Confirm the following