Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding a resilience strategy without explicit options #2068

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Apr 22, 2024

Pull Request

The issue or feature being addressed

Resolves #1985

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.69%. Comparing base (ef84594) to head (024d026).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2068      +/-   ##
==========================================
+ Coverage   83.67%   83.69%   +0.02%     
==========================================
  Files         312      312              
  Lines        7106     7115       +9     
  Branches     1054     1054              
==========================================
+ Hits         5946     5955       +9     
  Misses        789      789              
  Partials      371      371              
Flag Coverage Δ
linux 83.69% <100.00%> (+0.02%) ⬆️
macos 83.69% <100.00%> (+0.02%) ⬆️
windows 83.69% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1 +1,4 @@
#nullable enable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should update my automation PR to move things to the Shipped file too...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martincostello martincostello added this to the v8.3.2 milestone Apr 22, 2024
@martintmk martintmk merged commit 958c52a into main Apr 22, 2024
18 checks passed
@martintmk martintmk deleted the mtomka/addstrategy-no-options branch April 22, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Add AddStrategy API with no options
2 participants