Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for macOS 14 #2079

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Fix CI for macOS 14 #2079

merged 2 commits into from
Apr 29, 2024

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Apr 26, 2024

The update of the macos-latest runner label from macOS 12 to 14 has broken the CI.

#2078 (comment)

This appears to be because the .NET 6 SDK is not installed by default on the macOS 14 runner, so Polly.Specs fails as it runs tests with the .NET 6 runtime.

Empty commit to use as a starting point.
Explicitly install the .NET 6 and 7 SDKs, as the macOS 14 runner does not have .NET 6 installed.
@martincostello martincostello added this to the v8.4.0 milestone Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.69%. Comparing base (07f09a6) to head (d7bad63).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2079   +/-   ##
=======================================
  Coverage   83.69%   83.69%           
=======================================
  Files         312      312           
  Lines        7114     7114           
  Branches     1054     1054           
=======================================
  Hits         5954     5954           
  Misses        789      789           
  Partials      371      371           
Flag Coverage Δ
linux 83.69% <ø> (ø)
macos 83.69% <ø> (ø)
windows 83.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello marked this pull request as ready for review April 26, 2024 09:02
@martincostello martincostello merged commit c97c364 into main Apr 29, 2024
18 checks passed
@martincostello martincostello deleted the fix-macos-ci branch April 29, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant