Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDE0011 warning #2085

Merged
merged 13 commits into from
Apr 29, 2024
Merged

Fix IDE0011 warning #2085

merged 13 commits into from
Apr 29, 2024

Conversation

iamdmitrij
Copy link
Contributor

Pull Request

The issue or feature being addressed

#1290

Details on the issue fix or feature implementation

  • Added braces to if/while statements
  • Disabled IDE0011 warning suppression

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@iamdmitrij iamdmitrij changed the title Fix IDE0011 Fix IDE0011 warning Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.70%. Comparing base (08d7bc4) to head (3c4e6bd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2085      +/-   ##
==========================================
+ Coverage   83.69%   83.70%   +0.01%     
==========================================
  Files         312      312              
  Lines        7114     7120       +6     
  Branches     1054     1054              
==========================================
+ Hits         5954     5960       +6     
  Misses        789      789              
  Partials      371      371              
Flag Coverage Δ
linux 83.70% <100.00%> (+0.01%) ⬆️
macos 83.70% <100.00%> (?)
windows 83.70% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamdmitrij iamdmitrij marked this pull request as ready for review April 29, 2024 11:19
@martincostello martincostello added this to the v8.4.0 milestone Apr 29, 2024
@martincostello martincostello enabled auto-merge (squash) April 29, 2024 11:29
@martincostello martincostello merged commit 4ba2086 into App-vNext:main Apr 29, 2024
15 of 18 checks passed
@iamdmitrij iamdmitrij deleted the IDE0011 branch April 29, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants