Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3253/S6605/SA1625/S103 warnings #2086

Merged
merged 19 commits into from
Apr 29, 2024
Merged

Conversation

iamdmitrij
Copy link
Contributor

@iamdmitrij iamdmitrij commented Apr 29, 2024

Pull Request

The issue or feature being addressed

#1290

S103

  • Add SonarLint.xml configuration file
  • Set S103 rule's maximumLineLength to 500
  • Fix inappropriate string lengths > 500

Others

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@iamdmitrij iamdmitrij changed the title Fix warnings S3253/S6605/SA1625/S103 Fix S3253/S6605/SA1625/S103 warnings Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.72%. Comparing base (4ba2086) to head (f835153).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2086      +/-   ##
==========================================
+ Coverage   83.70%   83.72%   +0.01%     
==========================================
  Files         312      312              
  Lines        7120     7126       +6     
  Branches     1054     1054              
==========================================
+ Hits         5960     5966       +6     
  Misses        789      789              
  Partials      371      371              
Flag Coverage Δ
linux ?
macos 83.72% <100.00%> (+0.01%) ⬆️
windows 83.72% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamdmitrij iamdmitrij marked this pull request as ready for review April 29, 2024 11:39
src/Polly/Bulkhead/BulkheadSyntax.cs Outdated Show resolved Hide resolved
src/Polly/Timeout/AsyncTimeoutSyntax.cs Outdated Show resolved Hide resolved
src/Polly/Timeout/AsyncTimeoutSyntax.cs Outdated Show resolved Hide resolved
src/Polly/Bulkhead/AsyncBulkheadSyntax.cs Show resolved Hide resolved
@martincostello martincostello merged commit 31f7cce into App-vNext:main Apr 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants