Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SA1615/SA1623 warnings #2091

Merged
merged 5 commits into from
May 2, 2024
Merged

Conversation

iamdmitrij
Copy link
Contributor

@iamdmitrij iamdmitrij commented May 2, 2024

Pull Request

The issue or feature being addressed

#1290

Details on the issue fix or feature implementation

  • Fix SA1615 by adding documentation to return values
  • Fix SA1623 by prefixing property docs to Gets/Sets

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.72%. Comparing base (a31bdc2) to head (bd0bac6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2091   +/-   ##
=======================================
  Coverage   83.72%   83.72%           
=======================================
  Files         312      312           
  Lines        7126     7126           
  Branches     1054     1054           
=======================================
  Hits         5966     5966           
  Misses        789      789           
  Partials      371      371           
Flag Coverage Δ
linux 83.72% <ø> (ø)
macos 83.72% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamdmitrij
Copy link
Contributor Author

Noticed that SA1623 can be fixed without suppressing rule. Will push new changes.

src/Polly/PolicyBuilder.cs Outdated Show resolved Hide resolved
@iamdmitrij
Copy link
Contributor Author

SA1623 is now fixed without .editorconfig suppression.

@martincostello martincostello added this to the v8.4.0 milestone May 2, 2024
src/Polly/Context.cs Outdated Show resolved Hide resolved
Co-authored-by: Martin Costello <martin@martincostello.com>
@martincostello martincostello enabled auto-merge (squash) May 2, 2024 15:57
@martincostello
Copy link
Member

Thanks again!

@martincostello martincostello merged commit 341d3a1 into App-vNext:main May 2, 2024
15 checks passed
@iamdmitrij iamdmitrij deleted the SA1615 branch May 15, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants