-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SA1615/SA1623 warnings #2091
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2091 +/- ##
=======================================
Coverage 83.72% 83.72%
=======================================
Files 312 312
Lines 7126 7126
Branches 1054 1054
=======================================
Hits 5966 5966
Misses 789 789
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Noticed that SA1623 can be fixed without suppressing rule. Will push new changes. |
SA1623 is now fixed without |
Co-authored-by: Martin Costello <martin@martincostello.com>
Thanks again! |
Pull Request
The issue or feature being addressed
#1290
Details on the issue fix or feature implementation
Gets
/Sets
Confirm the following