Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDE1006 warning #2112

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix IDE1006 warning #2112

merged 2 commits into from
May 16, 2024

Conversation

iamdmitrij
Copy link
Contributor

@iamdmitrij iamdmitrij commented May 16, 2024

Pull Request

The issue or feature being addressed

#1290

Details on the issue fix or feature implementation

  • Suppress IDE1006 in the code or fix the warning

Similar concept to #2111, if warning related to public API - suppress in the code, otherwise fix.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Fix public API file

Remove breaking changes from PublicAPI.Shipped.txt

Move suppressions above summary comments

Remove S3872
@martincostello martincostello enabled auto-merge (squash) May 16, 2024 06:13
@martincostello martincostello merged commit fae7486 into App-vNext:main May 16, 2024
16 checks passed
@iamdmitrij iamdmitrij deleted the IDE1006-fix branch May 16, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants