Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SA1649 warning #2173

Conversation

Zombach
Copy link
Contributor

@Zombach Zombach commented Jul 3, 2024

Pull Request

The issue or feature being addressed

#1290

Details on the issue fix or feature implementation

  • Suppress SA1649 in the code or fix the warning

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.80%. Comparing base (e622a7d) to head (503a5ef).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2173   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files         313      313           
  Lines        7161     7161           
  Branches     1060     1060           
=======================================
  Hits         6001     6001           
  Misses        789      789           
  Partials      371      371           
Flag Coverage Δ
linux 83.80% <ø> (ø)
macos 83.80% <ø> (ø)
windows 83.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit c542b0e into App-vNext:main Jul 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants