Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S4049 warning #2195

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Zombach
Copy link
Contributor

@Zombach Zombach commented Jul 12, 2024

Pull Request

The issue or feature being addressed

#1290

Details on the issue fix or feature implementation

  • Suppress S4049 in the code or fix the warning

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

I will conditionally divide the partitions by directory names

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.80%. Comparing base (40562a9) to head (f367e43).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2195   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files         313      313           
  Lines        7162     7162           
  Branches     1060     1060           
=======================================
  Hits         6002     6002           
  Misses        789      789           
  Partials      371      371           
Flag Coverage Δ
linux 83.80% <ø> (ø)
macos 83.80% <ø> (ø)
windows 83.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit c90c0f6 into App-vNext:main Jul 12, 2024
18 checks passed
@Zombach Zombach deleted the zombach/remove-warning-s4049 branch July 12, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants