Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning CA1062#CacheTResultSyntax #2241

Conversation

Zombach
Copy link
Contributor

@Zombach Zombach commented Jul 22, 2024

Pull Request

The issue or feature being addressed

#2215

Details on the issue fix or feature implementation

  • Suppress CA1062 in src/Polly/Caching/CacheTResultSyntax.cs or fix the warning

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 29.09091% with 39 lines in your changes missing coverage. Please review.

Project coverage is 83.68%. Comparing base (72331dc) to head (b424c23).

Files Patch % Lines
src/Polly/Caching/CacheTResultSyntax.cs 29.09% 31 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
- Coverage   84.00%   83.68%   -0.33%     
==========================================
  Files         313      313              
  Lines        7227     7275      +48     
  Branches     1078     1087       +9     
==========================================
+ Hits         6071     6088      +17     
- Misses        785      809      +24     
- Partials      371      378       +7     
Flag Coverage Δ
linux 83.68% <29.09%> (-0.33%) ⬇️
macos 83.68% <29.09%> (-0.33%) ⬇️
windows 83.68% <29.09%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit cd015e7 into App-vNext:main Jul 23, 2024
16 of 18 checks passed
@Zombach Zombach deleted the remove-warning-ca1062#cache-t-result-syntax branch July 24, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants