Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S4225 warnings of extension methods for object class #2253

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

sukreshmanda
Copy link
Contributor

@sukreshmanda sukreshmanda commented Jul 29, 2024

Pull Request

This includes warning suppression for IDE0022 as it is blocking the build

The issue or feature being addressed

#1290

Details on the issue fix or feature implementation

  • Adding extension methods on object type is not recommended .
  • Using Dictionary<string, object> will solve the issue. So no need for test/Polly.Specs/Helpers/ObjectExtensions.cs

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (411cfdc) to head (030c162).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2253      +/-   ##
==========================================
+ Coverage   85.33%   85.35%   +0.02%     
==========================================
  Files         313      313              
  Lines        7444     7444              
  Branches     1122     1122              
==========================================
+ Hits         6352     6354       +2     
+ Misses        746      745       -1     
+ Partials      346      345       -1     
Flag Coverage Δ
linux 85.35% <ø> (+0.02%) ⬆️
macos 85.33% <ø> (ø)
windows 85.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martincostello martincostello merged commit 8a8f3d8 into App-vNext:main Jul 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants