Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report last attempt as error if it would be handled #2291

Conversation

peter-csala
Copy link
Contributor

Pull Request

Details on the issue fix or feature implementation

  • If the retry exhausted all of its attempts then report the ExecutionAttempt as Error if it would handle it
  • If the retry exhausted all of its attempts then report the ExecutionAttempt as Warning if it would not handle it

Missing

  • Update documentation

Out of scope

  • This PR does not include changes for hedging strategy

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (957444f) to head (3b0dc30).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2291      +/-   ##
==========================================
+ Coverage   85.35%   85.38%   +0.02%     
==========================================
  Files         313      313              
  Lines        7444     7457      +13     
  Branches     1122     1124       +2     
==========================================
+ Hits         6354     6367      +13     
  Misses        745      745              
  Partials      345      345              
Flag Coverage Δ
linux 85.38% <100.00%> (+0.02%) ⬆️
macos 85.38% <100.00%> (+0.02%) ⬆️
windows 85.35% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello added this to the v8.4.2 milestone Sep 17, 2024
@martincostello
Copy link
Member

Update documentation

Are you planning on adding to this PR, or in another one?

@peter-csala
Copy link
Contributor Author

Update documentation

Are you planning on adding to this PR, or in another one?

Yes, I will do that tomorrow morning.

@peter-csala
Copy link
Contributor Author

@martincostello Could you please re-run the build / windows-latest step?

[xUnit.net 00:00:02.90] Polly.Specs.Utilities.SystemClockSpecs.SleepAsync_ShouldThrow_WhenCancellationRequested [FAIL]

This test seems a bit flaky :(

@martincostello
Copy link
Member

You don't have to ask any time that happens, I'll just do it anyway, as otherwise it's unmergeable.

docs/strategies/retry.md Outdated Show resolved Hide resolved
Co-authored-by: Martin Costello <martin@martincostello.com>
@martincostello martincostello enabled auto-merge (squash) September 18, 2024 07:43
@peter-csala
Copy link
Contributor Author

@martincostello , @martintmk What do you guys think, would it make sense to implement the same for hedging?

@martincostello martincostello merged commit 1c6f3aa into App-vNext:main Sep 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants