Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress S4039, CA1010 in Context.Dictionary #2329

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

ShawnWu33
Copy link
Contributor

Pull Request

The issue or feature being addressed

Related issue #1290

Details on the issue fix or feature implementation

Reason for supressing S4039: Same as existing supression CA1033, reason refers to PR #2193.
Reason for supressing CA1010: Fixing this warning requires removing implementation for IDictionary, implement only the generic type IDictionary<string, object>, which would be a breaking change, so supress it.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (faaa79d) to head (595e3ad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2329   +/-   ##
=======================================
  Coverage   85.40%   85.40%           
=======================================
  Files         313      313           
  Lines        7467     7467           
  Branches     1126     1126           
=======================================
  Hits         6377     6377           
  Misses        745      745           
  Partials      345      345           
Flag Coverage Δ
linux 85.37% <ø> (-0.03%) ⬇️
macos 85.40% <ø> (ø)
windows 85.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 4e7d099 into App-vNext:main Oct 7, 2024
18 checks passed
@ShawnWu33 ShawnWu33 deleted the supress_polly_warning branch October 7, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants