Skip to content

Conversation

@lchaoer
Copy link
Contributor

@lchaoer lchaoer commented May 29, 2025

Pull Request

The issue or feature being addressed

Fixed comments.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@lchaoer lchaoer closed this May 29, 2025
@lchaoer lchaoer reopened this May 29, 2025
@lchaoer
Copy link
Contributor Author

lchaoer commented May 29, 2025

@lchaoer please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree company="Microsoft"

@lchaoer
Copy link
Contributor Author

lchaoer commented May 29, 2025

hi @martincostello ,could you please review the PR, to fix a comment, thanks

Co-authored-by: Martin Costello <martin@martincostello.com>
@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (582ef97) to head (f94616e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2627   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         311      311           
  Lines        7329     7329           
  Branches     1013     1013           
=======================================
  Hits         7053     7053           
  Misses        222      222           
  Partials       54       54           
Flag Coverage Δ
linux 96.23% <ø> (ø)
macos 96.23% <ø> (ø)
windows 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello added this to the v8.6.0 milestone Jun 3, 2025
@martincostello martincostello merged commit c4193b5 into App-vNext:main Jun 3, 2025
26 checks passed
@martincostello
Copy link
Member

Thanks.

@github-actions
Copy link
Contributor

Thanks for your contribution @lchaoer - the changes from this pull request have been published as part of version 8.6.0 📦, which is now available from NuGet.org 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants