Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.2.2: Bug fixes, issue 818 #844

Merged
merged 9 commits into from
Apr 11, 2021
Merged

v7.2.2: Bug fixes, issue 818 #844

merged 9 commits into from
Apr 11, 2021

Conversation

martincostello
Copy link
Member

The issue or feature being addressed

#818 - When using HandleInner() not all AggregateExceptions are being checked

Details on the issue fix or feature implementation

#816 - The solution can now be built with the .NET 5.0 SDK
#823 - The timeoutStrategy parameter was not being used by the TimeoutAsync(Func<TimeSpan>, TimeoutStrategy, Func<Context, TimeSpan, Task, Task>) method
#824 - Recursively search all AggregateException inner exceptions for predicate matches when using HandleInner()
#839 - Polly now builds deterministically

Confirm the following

  • I started this PR by branching from the head of the latest dev vX.Y branch, or I have rebased on the latest dev vX.Y branch, or I have merged the latest changes from the dev vX.Y branch
  • I have targeted the PR to merge into the latest dev vX.Y branch as the base branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

martincostello and others added 9 commits January 23, 2021 15:06
Suppress the NETSDK1138 warning which otherwise causes the build to fail with .NET 5.0 SDK.
Fix typo in comment.
Set DisableImplicitNuGetFallbackFolder to try and resolve NU3005 error when building in AppVeyor.
Drop End-of-Life TFMs.
Add LTS TFMs at time of commit plus .NET 5.0.
Add a global.json to prefer not to use preview versions of .NET SDKs if they are installed on the local machine (such as via a Visual Studio preview).
Fix the timeoutStrategy parameter not being used.
…te matches when using HandleInner() (#824)

* Recursively search all AggregateException InnerExceptions for predicate matches when using HandleInner() #818

* Add tests for multiple nested aggregate exceptions #818
Resolve NuGet Package Explorer warnings.
Update versions and CHANGELOG for v7.2.2.
Change copyright year to be determined dynamically.
@martincostello martincostello added this to the v7.2.2 milestone Apr 11, 2021
@martincostello martincostello merged commit 174cc53 into master Apr 11, 2021
@martincostello martincostello deleted the v722-or-v730 branch April 11, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants