Suggestion for a less complicated API.

[sxleixer]

This should not be integrated into the master, you should just be able to see the deltas I've done in my branch. This PR is related to #961 demonstrating how it would feel to have interfaces instead of delegates to work with.

I think the impact on the perfomance should be miniscule if not null.

This approach should also be expanded to the TimeProvider and other functions. Please feel free to reach out to me.

[dnfadmin]

All CLA requirements met.

[martincostello]

Thanks for the pull request.

The "explosion" of parameters in the way to configure the policies has come up several times over the last year or so in issues, and it's something that's being considered for change in v8 (whenever that is).

Thoughts being thrown around have included removing all the different overloads/combinations, and replacing them with a single "options"/"settings" value that all the different possible configurations can be specified in a single place.

I don't think we'd want to add something like this in a v7.x as it just adds even more code and complexity to what we already have.

[martincostello]

Personally I think it's weird to have an interface be named callback, I would expect a delegate for such a name.

[sxleixer]

I made some updates upon your comments. Renaming some of the files. Added a proposal for type-based range checking (see e.g. RetryCountValue). Expanded the example for the non-async RetryPolicy.

[martincostello]

Development is now underway for Polly v8, where we hope the new API addresses various concerns about an over-complicated API surface - see #1048 for more information.

I'm going to close this issue due to this work and a lack of activity. Feel free to raise suggestions related to the new design if you have any suggestions that aren't covered by the new API.