Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: children of trash views and other user's private space should not appear in search #1146

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

khorshuheng
Copy link
Collaborator

Current API endpoint still return children of trash views and other user's private space's document in the search result. This PR will fix this by passing an eligible set of searchable view ids instead of a set of parent private space id and trash ids.

@khorshuheng khorshuheng requested a review from appflowy January 9, 2025 13:27
@khorshuheng khorshuheng force-pushed the fix-private-search-2 branch from 7e6583a to 44feb7a Compare January 9, 2025 16:14
@appflowy appflowy merged commit 832bd7f into main Jan 10, 2025
9 of 11 checks passed
@appflowy appflowy deleted the fix-private-search-2 branch January 10, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants