feat: return transaction for workspace database operation #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horusiath
reviewed
Dec 6, 2024
| .delete_database(&mut self.collab.transact_mut(), database_id); | ||
| pub fn delete_database(&mut self, database_id: &str) -> TransactionMut { | ||
| let mut txn = self.collab.transact_mut(); | ||
| self.body.delete_database(&mut txn, database_id); |
There was a problem hiding this comment.
As you can see here, you don't need to return transaction. You can just call self.collab.transact_mut + self.body.delete_database. Because both self.collab and self.body are split in every collab type, creating transaction should never be a problem.
Horusiath
reviewed
Dec 6, 2024
| @@ -56,7 +56,7 @@ impl WorkspaceDatabase { | |||
| /// Create a new [DatabaseMeta] for the given database id and view id | |||
| /// use [Self::update_database] to attach more views to the existing database. | |||
| /// | |||
| pub fn add_database(&mut self, database_id: &str, view_ids: Vec<String>) { | |||
| pub fn add_database(&mut self, database_id: &str, view_ids: Vec<String>) -> TransactionMut { | |||
There was a problem hiding this comment.
It's better to move add_database logic to body and provide transaction from outside. What if you want to call this method, while you already had transaction acquired? This would cause a deadlock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return transaction for workspace database operation, so that the callers can get the encoded update.