Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Sucessfully to build workable version for windows (Rust target: x86_64-pc-windows-msvc), request to contribute #19

Closed
pdckxd opened this issue Nov 17, 2021 · 5 comments
Closed

[FR] Sucessfully to build workable version for windows (Rust target: x86_64-pc-windows-msvc), request to contribute #19

pdckxd opened this issue Nov 17, 2021 · 5 comments

Comments

@pdckxd
Copy link
Contributor

pdckxd commented Nov 17, 2021 •
edited
Loading

1~3 main use cases of the proposed feature
Can I issue pull request to support x86_64-pc-windows-msvc target for rust-lib?

what types of users can benefit from using your proposed feature
n/a

Additional context
n/a

image
@pdckxd pdckxd changed the title [FR] Sucessfully to build workable version for windows (Rust target: x86_64-pc-windows-msvc) [FR] Sucessfully to build workable version for windows (Rust target: x86_64-pc-windows-msvc), request to contribute Nov 17, 2021
@annieappflowy
Copy link
Collaborator

100%
You rock!!!!

@appflowy
Copy link
Contributor

appflowy commented Nov 17, 2021 •
edited
Loading

@pdckxd Wow, amazing! I am stuck on symbols not found issues. There's must be something wrong with my CMake scripts.

Open new PR, please! Join the discord for further discussion if you want. https://discord.gg/GYwtdnAR

@pdckxd
Copy link
Contributor Author

pdckxd commented Nov 17, 2021

Sure, I will file PR later today after work.

pdckxd added a commit to pdckxd/appflowy that referenced this issue Nov 17, 2021
@pdckxd
AppFlowy-IO#19 - [FR] Successfully to build workable version for wind…
5ee3797 
…ows (Rust target: x86_64-pc-windows-msvc), request to contribute

1. scripts\flowy-tool\Cargo.toml
  - Remove shell dependency which does not support windows
2. scripts\makefile\env.toml
  - Enhance environment checking for building app on windows
3. scripts\flowy-tool\src\util\file.rs
  - Trim unnecessary prefix "\\?\" for std::fs::canonicalize(root) on windows
4.  scripts\makefile\flutter.toml
  - add dependency for "tasks.appflowy-windows" to copy dart_ffi.dll from rust build folder to flutter build folder
5. scripts\flowy-tool\src\proto\proto_gen.rs
  - Remove dir by using platform independent code rather than calling *nix shell command
6. scripts\makefile\protobuf.toml
  - tasks.gen_dart_event: call duckscript to gen_dart_event on windows platform
@pdckxd pdckxd mentioned this issue Nov 17, 2021
Merged
@pdckxd
Copy link
Contributor Author

pdckxd commented Nov 17, 2021

hi @appflowy, can you help to review?

PS: didn't get enough time to verify on MacOS.

appflowy added a commit that referenced this issue Nov 17, 2021
@appflowy
Merge pull request #21 from pdckxd/main
6536098 
#19 - [FR] Successfully to build workable version for windows (Rust t…
@pdckxd
Copy link
Contributor Author

pdckxd commented Nov 17, 2021

Thanks appflowy. Closing this issus

@pdckxd pdckxd closed this as completed Nov 17, 2021
appflowy pushed a commit that referenced this issue Dec 10, 2021
@pdckxd
#19 - [FR] Successfully to build workable version for windows (Rust t…
2a66f5b 
…arget: x86_64-pc-windows-msvc), request to contribute

1. scripts\flowy-tool\Cargo.toml
  - Remove shell dependency which does not support windows
2. scripts\makefile\env.toml
  - Enhance environment checking for building app on windows
3. scripts\flowy-tool\src\util\file.rs
  - Trim unnecessary prefix "\\?\" for std::fs::canonicalize(root) on windows
4.  scripts\makefile\flutter.toml
  - add dependency for "tasks.appflowy-windows" to copy dart_ffi.dll from rust build folder to flutter build folder
5. scripts\flowy-tool\src\proto\proto_gen.rs
  - Remove dir by using platform independent code rather than calling *nix shell command
6. scripts\makefile\protobuf.toml
  - tasks.gen_dart_event: call duckscript to gen_dart_event on windows platform
appflowy added a commit that referenced this issue Dec 10, 2021
@appflowy
Merge pull request #21 from pdckxd/main
557e34c 
#19 - [FR] Successfully to build workable version for windows (Rust t…
zoli referenced this issue in LucasXu0/AppFlowy Aug 30, 2023
@Xazin @LucasXu0
feat: shrinkWrap option for AppFlowyEditor (#20)
f0a357b 
* feat: shrinkWrap option for AppFlowyEditor

Relates: #19

* test: add autoFocus tests for editor service

* chore: Update lib/src/core/transform/operation.dart

Co-authored-by: Mathias Mogensen <42929161+Xazin@users.noreply.github.com>

---------

Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io>
@q200892907 q200892907 mentioned this issue Feb 23, 2024
Closed
839900146 pushed a commit to 839900146/AppFlowy that referenced this issue Jun 6, 2024
@appflowy
refactor: save collab data in pg (AppFlowy-IO#19)
384501a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pdckxd @annieappflowy @appflowy