Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Keyboard word-for-word text navigation not working #2071

Closed
rlndkhlr opened this issue Mar 21, 2023 · 5 comments
Closed

[Bug] Keyboard word-for-word text navigation not working #2071

rlndkhlr opened this issue Mar 21, 2023 · 5 comments
Assignees
Labels
bug Something isn't working editor features related to the rich-text editor good first issue for devs for the community members to claim good first issue for experienced devs for the experienced community developers to claim help wanted for the community members to claim
Milestone

Comments

@rlndkhlr
Copy link

Bug Description

Navigating from word to word using the keyboard's option and arrow keys does not work, the text cursor does not move.

How to Reproduce

On macOS, open/create a document with a few sentences. When trying to use the option ( ⌥ ) key and left/right arrows to jump between or select single words, the cursor does not move.

Expected Behavior

⌥ + left/right arrows: jump with cursor from word to word (❌)
⇧ + ⌥ + left/right arrows: select single words (❌)
⌘ + left/right arrows: jump from cursor position to line beginning or end (✅)
⇧ + ⌘ + left/right arrows: select from cursor position to line beginning or end (✅)

Operating System

macOS Ventura 13.1

AppFlowy Version(s)

Version 0.1.0 (1) & Version 0.1.1 (1)

Screenshots

No response

Additional Context

No response

@LucasXu0 LucasXu0 added bug Something isn't working good first issue for experienced devs for the experienced community developers to claim help wanted for the community members to claim good first issue for devs for the community members to claim editor features related to the rich-text editor labels Mar 22, 2023
@LucasXu0
Copy link
Collaborator

LucasXu0 commented Mar 22, 2023

Hey, @rlndkhlr. I tested the ⇧ + ⌥ + left/right arrows: select single words on my macOS. It works fine.

  ShortcutEvent(
    key: 'Cursor left word select',
    command: 'shift+alt+arrow left',
    windowsCommand: 'shift+alt+arrow left',
    linuxCommand: 'shift+alt+arrow left',
    handler: cursorLeftWordSelect,
  ),
  ShortcutEvent(
    key: 'Cursor right word select',
    command: 'shift+alt+arrow right',
    windowsCommand: 'shift+alt+arrow right',
    linuxCommand: 'shift+alt+arrow right',
    handler: cursorRightWordSelect,
  ),

@rlndkhlr
Copy link
Author

Thanks for testing. Tested it again, also on a different machine (and with the latest version) and it works here, too. Must have been a user error in this case, sorry about that.

Unfortunately, the ⌥ + left/right arrows: jump from word to word still does not work. 😔

@Xazin
Copy link
Contributor

Xazin commented Mar 22, 2023

Thanks for testing. Tested it again, also on a different machine (and with the latest version) and it works here, too. Must have been a user error in this case, sorry about that.

Unfortunately, the ⌥ + left/right arrows: jump from word to word still does not work. 😔

I've made a PR for this on the editor, it was indeed missing.

@annieappflowy annieappflowy moved this to In progress in AppFlowy Roadmap Mar 23, 2023
@annieappflowy annieappflowy added this to the v0.1.2 milestone Mar 23, 2023
@annieappflowy annieappflowy modified the milestones: v0.1.2, v0.1.3 Apr 3, 2023
@annieappflowy
Copy link
Collaborator

Confirm it works on Windows
I also updated the shortcuts guide

@github-project-automation github-project-automation bot moved this from In progress to Done in AppFlowy Roadmap Apr 24, 2023
@rlndkhlr
Copy link
Author

Thanks all for fixing. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor features related to the rich-text editor good first issue for devs for the community members to claim good first issue for experienced devs for the experienced community developers to claim help wanted for the community members to claim
Projects
Archived in project
Development

No branches or pull requests

4 participants