Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alt + arrow key to move cursor one word #28

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

Xazin
Copy link
Contributor

@Xazin Xazin commented Mar 22, 2023

@Xazin Xazin force-pushed the feat/gh-2071-2/alt-move-cursor branch from 012449d to 63f855e Compare March 22, 2023 14:32
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #28 (5585146) into main (16b64cf) will decrease coverage by 0.13%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   77.96%   77.84%   -0.13%     
==========================================
  Files         123      123              
  Lines        7053     7094      +41     
==========================================
+ Hits         5499     5522      +23     
- Misses       1554     1572      +18     
Impacted Files Coverage Δ
...nternal_key_event_handlers/arrow_keys_handler.dart 80.65% <81.81%> (+0.11%) ⬆️
...rvice/shortcut_event/built_in_shortcut_events.dart 98.13% <100.00%> (+0.07%) ⬆️

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xazin
Copy link
Contributor Author

Xazin commented Mar 22, 2023

@LucasXu0 When you have time, can you guide me on how to resolve the issue with tests. I had to make changes because I took over the command that the failing tests were taking advantage of.

Copy link
Contributor

@MayurSMahajan MayurSMahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In test/service/shortcut_event/shortcut_event_test.dart file when you are updating the command to ctrl+arrow left, in macOSCommand you want to use meta instead of ctrl. On line 66: macOsCommand: 'meta+arrow left',

@Xazin Xazin force-pushed the feat/gh-2071-2/alt-move-cursor branch from 14ea48d to f5795fb Compare March 23, 2023 07:06
@Xazin Xazin force-pushed the feat/gh-2071-2/alt-move-cursor branch from f5795fb to 5585146 Compare March 23, 2023 07:11
@Xazin
Copy link
Contributor Author

Xazin commented Mar 23, 2023

Thanks @LucasXu0 - That was the issue ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants