-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support markdown to bold text #1187
Conversation
return PhysicalKeyboardKey.digit8; | ||
} | ||
if (this == LogicalKeyboardKey.underscore) { | ||
return PhysicalKeyboardKey.minus; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what should be here, could you advise with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minus
is fine. Since I often encountered some error reports, like flutter/flutter#96022, when simulating keyboard pressing in the test before, I didn't use the Flutter built-in keyboard testing function directly but passed the keyboard event to the keyboard_service
. The mock keyboard events need to correspond to the logical keys and physical keys, so there is no problem to use minus
here.
Codecov Report
@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
+ Coverage 78.46% 78.71% +0.25%
==========================================
Files 105 106 +1
Lines 5229 5291 +62
==========================================
+ Hits 4103 4165 +62
Misses 1126 1126
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
# Conflicts: # frontend/app_flowy/packages/appflowy_editor/test/infra/test_raw_key_event.dart
feat: Support markdown to bold text
To bold text, add two asterisks or underscores before and after a word or phrase. To bold the middle of a word for emphasis, add two asterisks without spaces around the letters.
out.mp4
Reference:
#1099