Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support markdown to bold text #1187

Merged
merged 6 commits into from
Oct 8, 2022
Merged

feat: Support markdown to bold text #1187

merged 6 commits into from
Oct 8, 2022

Conversation

tekdel
Copy link
Contributor

@tekdel tekdel commented Sep 27, 2022

To bold text, add two asterisks or underscores before and after a word or phrase. To bold the middle of a word for emphasis, add two asterisks without spaces around the letters.

image

out.mp4

Reference:
#1099

return PhysicalKeyboardKey.digit8;
}
if (this == LogicalKeyboardKey.underscore) {
return PhysicalKeyboardKey.minus;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what should be here, could you advise with that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minus is fine. Since I often encountered some error reports, like flutter/flutter#96022, when simulating keyboard pressing in the test before, I didn't use the Flutter built-in keyboard testing function directly but passed the keyboard event to the keyboard_service. The mock keyboard events need to correspond to the logical keys and physical keys, so there is no problem to use minus here.

@tekdel tekdel marked this pull request as ready for review September 27, 2022 20:37
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #1187 (1841fb2) into main (06f1d52) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
+ Coverage   78.46%   78.71%   +0.25%     
==========================================
  Files         105      106       +1     
  Lines        5229     5291      +62     
==========================================
+ Hits         4103     4165      +62     
  Misses       1126     1126              
Impacted Files Coverage Δ
...itor/lib/src/document/built_in_attribute_keys.dart 100.00% <ø> (ø)
...ndlers/markdown_syntax_to_styled_text_handler.dart 100.00% <100.00%> (ø)
...rvice/shortcut_event/built_in_shortcut_events.dart 97.64% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@annieappflowy annieappflowy added editor features related to the rich-text editor hacktoberfest labels Oct 3, 2022
# Conflicts:
#	frontend/app_flowy/packages/appflowy_editor/test/infra/test_raw_key_event.dart
@LucasXu0 LucasXu0 merged commit 8d6e1cd into AppFlowy-IO:main Oct 8, 2022
zoli pushed a commit to LucasXu0/AppFlowy that referenced this pull request Aug 30, 2023
feat: Support markdown to bold text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor features related to the rich-text editor hacktoberfest HACKTOBERFEST-ACCEPTED
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants