Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] : add custom title bar #2169

Closed
wants to merge 16 commits into from
Closed

[feat] : add custom title bar #2169

wants to merge 16 commits into from

Conversation

GouravShDev
Copy link
Contributor

closes #1995

  • Added title bar in home screen using bitsdojo_window as mentioned in the issue.
  • used default colors for window button apart from icon button which uses primary color
  • Tested only on windows machine as I don't have other OS machines

Light Theme:
image
Dark Theme:
image

@GouravShDev GouravShDev force-pushed the feat/custom_title_bar branch from fe7ce1c to 05d924b Compare April 2, 2023 17:07
@LucasXu0 LucasXu0 requested a review from a-wallen April 3, 2023 01:45
@LucasXu0
Copy link
Collaborator

LucasXu0 commented Apr 3, 2023

There is a class named AppWindow that manages the size and title of window. However, it seems that we should keep only one of the two options: either windows_manager or bitsdojo_window.

@LucasXu0 LucasXu0 self-requested a review April 3, 2023 01:48
@a-wallen
Copy link
Contributor

a-wallen commented Apr 3, 2023

I agree @LucasXu0, but maybe in a separate PR. If this lands, I will make a separate issue.

@annieappflowy annieappflowy added the improvements improvements on an existing feature label Apr 4, 2023
@annieappflowy annieappflowy added this to the v0.1.3 milestone Apr 4, 2023
@a-wallen a-wallen mentioned this pull request Apr 5, 2023
Closed
@a-wallen a-wallen force-pushed the feat/custom_title_bar branch from 05d924b to dbd1d06 Compare April 6, 2023 22:04
@a-wallen
Copy link
Contributor

a-wallen commented Apr 6, 2023

The integration tests failed on macOS since Flutter 3.7.5 dropped OpenGL support. Your PR was probably failing for reasons unrelated to your changes. I rebased on the commits that resolved this issue #2200.

@Xazin
Copy link
Contributor

Xazin commented Apr 12, 2023

Hey @GouravShDev If you need help let me know, I am available.

@GouravShDev
Copy link
Contributor Author

@Xazin was busy this week will probably work on this on upcoming weekend. Thanks for asking

@GouravShDev
Copy link
Contributor Author

  • Remove windows button colors as they were just default color.
  • Used colorscheme's error for close button it was close to red.
  • change file_picker because it was giving compiler error when using <=5.0.0 version.

@a-wallen
Copy link
Contributor

Looks good @GouravShDev, I'm wondering if it would look better if the title bar color was the same as the left navigation bar color. Do you mind sending a screenshot so that we can see what it would look like? See the image below as an example.

image

@GouravShDev
Copy link
Contributor Author

@a-wallen sure.

Dark Mode:

image

Light Mode:

image

@GouravShDev
Copy link
Contributor Author

Should I add applogo in title bar as it was by default previously ?

OLD:

image

NEW:

image

image

@annieappflowy
Copy link
Collaborator

@a-wallen sure.

Dark Mode:

image

Light Mode:

image

@hyj1204 could you provide feedback on the design?
I personally feel one logo is enough

@hyj1204
Copy link
Contributor

hyj1204 commented Apr 17, 2023

@annieappflowy
I agree. I think we don't need the logo on the title bar.
@GouravShDev
Could you help change the icon color to the tertiary color from the default theme? I think it would looks more consistent. Others looks good to me.
image

@GouravShDev
Copy link
Contributor Author

@hyj1204 sure.

richardshiue and others added 2 commits May 4, 2023 11:05
@richardshiue @appflowy
feat: show unscheduled events in calendar toolbar (AppFlowy-IO#2411)
db8d030 
* refactor: use same show row detail function

* fix: adjust popover offset

* feat: show unscheduled events in toolbar

* chore: apply suggestions from Xazin

* refactor: refactor list item into separate widget

---------

Co-authored-by: Nathan.fooo <86001920+appflowy@users.noreply.github.com>
@richardshiue
fix: default include time (AppFlowy-IO#2444)
5d0a349 
* fix: default include time

* chore: clarify logic and add comments
@annieappflowy annieappflowy modified the milestones: v0.1.4, v0.1.5 May 4, 2023
@GouravShDev
Copy link
Contributor Author

@Xazin Thanks.
I'll check for windows.

@GouravShDev GouravShDev marked this pull request as draft May 5, 2023 19:17
@Xazin
Copy link
Contributor

Xazin commented May 5, 2023

@Xazin Thanks.
I'll check for windows.

Glad I could help.

Let me know if there are any issues.

@GouravShDev
Copy link
Contributor Author

It's working on windows. But we might need to check for Linux as well.

@GouravShDev GouravShDev marked this pull request as ready for review May 7, 2023 13:30
@LucasXu0
Copy link
Collaborator

macOS

main branch.

Screenshot 2023-05-11 at 15 53 01

this PR.

Screenshot 2023-05-11 at 15 54 00

@GouravShDev, this PR should not affect the existing style for macOS. I suggest implementing a different titlebar style for macOS and Windows/Linux. The style for macOS should be frameless, while the style for Windows or Linux should be a normal titlebar style.

@Xazin Xazin mentioned this pull request May 11, 2023
Closed
@Xazin
Copy link
Contributor

Xazin commented May 11, 2023

macOS

main branch.

Screenshot 2023-05-11 at 15 53 01 ### this PR. Screenshot 2023-05-11 at 15 54 00 @GouravShDev, this PR should not affect the existing style for macOS. I suggest implementing a different titlebar style for macOS and Windows/Linux. The style for macOS should be frameless, while the style for Windows or Linux should be a normal titlebar style.

Alright, I'll resolve the MacOS issue.

Do we have someone with linux who can test this branch @LucasXu0 ?

@a-wallen
Copy link
Contributor

Since this thread became unexpectedly long I should probably mention that I appreciate everyone who has contributed to this @GouravShDev @Xazin @LucasXu0 @hyj1204 🙌

@annieappflowy annieappflowy modified the milestones: v0.1.5, v0.2.1 May 12, 2023
@Xazin
Copy link
Contributor

Xazin commented May 26, 2023

@GouravShDev I'll make a PR to your branch next week to fix the MacOS title bar.

@annieappflowy annieappflowy modified the milestones: v0.2.1, v0.2.2 Jun 12, 2023
@annieappflowy
Copy link
Collaborator

Is this PR ready to merge? @GouravShDev

@annieappflowy annieappflowy modified the milestones: v0.2.2, v0.2.3 Jun 16, 2023
@annieappflowy
Copy link
Collaborator

Close this PR because no progress has been made since last month

@annieappflowy annieappflowy removed this from the v0.2.3 milestone Jun 23, 2023
@istanb84 istanb84 mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-wallen a-wallen a-wallen left review comments

@LucasXu0 LucasXu0 Awaiting requested review from LucasXu0

Assignees

@GouravShDev GouravShDev

Labels
improvements improvements on an existing feature
Projects
AppFlowy Roadmap
Status: Blocked
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Windows 10 Native App Bar Does Not Respond To System Set Theme
7 participants
@GouravShDev @LucasXu0 @a-wallen @Xazin @annieappflowy @hyj1204 @richardshiue