Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] add theme for snackbar #2194

Merged
merged 2 commits into from
Apr 7, 2023
Merged

[feat] add theme for snackbar #2194

merged 2 commits into from
Apr 7, 2023

Conversation

a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Apr 5, 2023 •
edited
Loading

Adds a theme for SnackBar in AppFlowy. There is no specification in any of the Figma files, so the theme is the same as the SettingsMenuOptions in the left panel of the settings menu.

Feature Preview

Light, Default
image
Dark, Default
image
Light, Dandelion
image
Dark, Dandelion
image
Light, Lavender
image
Dark, Lavender
image

fixes #2127

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@a-wallen a-wallen requested a review from hyj1204 April 5, 2023 05:15
@a-wallen
Copy link
Contributor Author

a-wallen commented Apr 5, 2023

No test, as this PR only adds theming changes.

hyj1204
hyj1204 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@hyj1204 hyj1204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-wallen a-wallen mentioned this pull request Apr 5, 2023
Closed
@a-wallen a-wallen merged commit ae2146f into main Apr 7, 2023
@annieappflowy annieappflowy added the improvements improvements on an existing feature label Apr 7, 2023
@annieappflowy annieappflowy added this to the v0.1.3 milestone Apr 7, 2023
@appflowy appflowy deleted the snackbar_theme branch May 26, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyj1204 hyj1204 hyj1204 approved these changes

Assignees
No one assigned
Labels
improvements improvements on an existing feature
Projects
AppFlowy Roadmap
Archived in project
Milestone
v0.1.3
Development

Successfully merging this pull request may close these issues.

[Bug] Snackbar theming
3 participants
@a-wallen @hyj1204 @annieappflowy