Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[feat] Create a "view" for all database references in a document" #2201

Closed
wants to merge 1 commit into from

Conversation

a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Apr 5, 2023

See #2200. Integration tests seem to be failing due to a timeout exception. After revert, I will try to re-run integration tests to see whether this PR is the root cause.

Unfortunately, the integration tests seem to run fine on local machines, they just happen to fail on GitHub Actions.

@a-wallen a-wallen requested a review from hyj1204 April 5, 2023 20:19
Copy link
Contributor

@hyj1204 hyj1204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-wallen a-wallen mentioned this pull request Apr 5, 2023
@a-wallen a-wallen force-pushed the revert-2083-view_of_database branch from 2ae878b to f7abb8b Compare April 5, 2023 21:32
@a-wallen
Copy link
Contributor Author

a-wallen commented Apr 5, 2023

rebased after changes made in https://github.com/AppFlowy-IO/AppFlowy/pull/2203/checks which should fix all Flutter-CI actions.

@a-wallen
Copy link
Contributor Author

a-wallen commented Apr 6, 2023

Closing as this doesn't seem to solve the root cause of the issue.

@a-wallen a-wallen closed this Apr 6, 2023
@appflowy appflowy deleted the revert-2083-view_of_database branch May 26, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants