Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mobile improvements for calendar #4027

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Xazin
Copy link
Collaborator

@Xazin Xazin commented Nov 27, 2023

  • Increases the "Day" size in Calendar
  • Fixes blank spaces when deleting events on mobile in calendar
  • Fixes duplicate events in calendar
  • Disable help center (temp)
  • Edit property directly from Column (long press) in Grid
  • Removes redundant path parameter for Compilation Failure

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (c659cf4) 54.55% compared to head (e86ad11) 54.59%.

Files Patch % Lines
...tation/database/mobile_calendar_events_screen.dart 0.00% 13 Missing ⚠️
...ttom_sheet/bottom_sheet_database_field_editor.dart 0.00% 11 Missing ⚠️
...presentation/widgets/header/mobile_field_cell.dart 0.00% 6 Missing ⚠️
..._view/widgets/setting/database_setting_action.dart 0.00% 2 Missing ⚠️
...ttings/widgets/theme_upload/theme_upload_view.dart 0.00% 2 Missing ⚠️
...dgets/setting/mobile_database_property_editor.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4027      +/-   ##
==========================================
+ Coverage   54.55%   54.59%   +0.03%     
==========================================
  Files         685      684       -1     
  Lines       31763    31753      -10     
==========================================
+ Hits        17329    17335       +6     
+ Misses      14434    14418      -16     
Flag Coverage Δ
appflowy_flutter_integrateion_test 52.99% <18.60%> (+0.03%) ⬆️
appflowy_flutter_unit_test 9.69% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prechayimmee prechayimmee mentioned this pull request Nov 27, 2023
4 tasks
@Xazin Xazin merged commit bfa9233 into AppFlowy-IO:main Nov 28, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant