Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shortcuts page remake #5567

Merged
merged 6 commits into from
Jun 19, 2024
Merged

Conversation

Xazin
Copy link
Contributor

@Xazin Xazin commented Jun 18, 2024

Closes: #5355 - Duplicates were removed earlier, and we can now translate all of the current shortcuts.
Closes: #3122

  • UI Redesign
  • Supports having commands without a keybinding (If overwritten due to a conflict)
  • Supports localizing the command by it's unique key

Feature Preview

To come...

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

github-actions bot commented Jun 18, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Message without source 18 warning contribute (via Fink 🐦)
Missing translation 2470 warning contribute (via Fink 🐦)

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (94f9349) to head (e27b9cf).
Report is 817 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main    #5567       +/-   ##
==========================================
+ Coverage   9.70%   86.74%   +77.04%     
==========================================
  Files        685      217      -468     
  Lines      31812     5032    -26780     
  Branches       0      831      +831     
==========================================
+ Hits        3086     4365     +1279     
+ Misses     28726      561    -28165     
- Partials       0      106      +106     
Flag Coverage Δ
appflowy_flutter_unit_test ?
appflowy_web_app 86.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xazin Xazin merged commit fa86480 into AppFlowy-IO:main Jun 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Duplicated shortcut entries and missing translation strings [FR] Search within the list of shortcuts
1 participant