FR: Users choose color from palette or picker #5041 #5677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
| lint rule | new reports | level | link |
|---|---|---|---|
| Missing translation | 78 | warning | contribute (via Fink 🐦) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5677 +/- ##
==========================================
- Coverage 86.74% 84.08% -2.66%
==========================================
Files 217 211 -6
Lines 5032 5115 +83
Branches 831 850 +19
==========================================
- Hits 4365 4301 -64
- Misses 561 722 +161
+ Partials 106 92 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…y-IO#5041) - Added `flex_color_picker` dependency. - Implemented a new color picker dialog with the following features: - Display Material predefined colors. - Include primary, accent, and shade colors, as well as a color wheel for selection. - Add a graphical opacity selector. - Enhanced the previous dialog to include an icon in a text field for opening the palette. - Added `suffixIcon` parameter to the `_ColorSettingTextField` class, making it reactive to tap gestures. - Utilized `ColorExtension` on the `Color` class to avoid namespace conflicts when converting colors to hexadecimal strings. - Added translation strings to english This commit addresses issue AppFlowy-IO#5041
gustamor
force-pushed
the
feat/user_choose_color_from_palette_or_picker_5041
branch
from
a3892c4 to
19dcc46
Compare
…y-IO#5041) - Added `flex_color_picker` dependency. - Implemented a new color picker dialog with the following features: - Display Material predefined colors. - Include primary, accent, and shade colors, as well as a color wheel for selection. - Add a graphical opacity selector. - Enhanced the previous dialog to include an icon in a text field for opening the palette. - Added `suffixIcon` parameter to the `_ColorSettingTextField` class, making it reactive to tap gestures. - Utilized `ColorExtension` on the `Color` class to avoid namespace conflicts when converting colors to hexadecimal strings. - Added translation strings to english This commit addresses issue AppFlowy-IO#5041
LucasXu0
reviewed
Jul 10, 2024
.tool-versions
Outdated
| @@ -0,0 +1 @@ | |||
| flutter 3.22.0-stable | |||
There was a problem hiding this comment.
please remove this file.
Comment on lines
108
to
115
| void updateColor(Color color) { | ||
| setState(() { | ||
| hexController.text = ColorExtension(color).toHexString().extractHex(); | ||
| opacityController.text = | ||
| ColorExtension(color).toHexString().extractOpacity(); | ||
| }); | ||
| updateSelectedColor(); | ||
| } |
There was a problem hiding this comment.
mark this function as private and move it below the initState function.
Comment on lines
267
to
296
| void _showColorPickerDialog({ | ||
| required BuildContext context, | ||
| String? title, | ||
| required Color currentColor, | ||
| required void Function(Color) updateColor, | ||
| }) { | ||
| const kColorCircleWidth = 46.0; | ||
| const kColorCircleHeight = 46.0; | ||
| const kColorCircleRadius = 23.0; | ||
| const kColorOpacityThumbRadius = 23.0; | ||
| const kDialogButtonPaddingHorizontal = 24.0; | ||
| const kDialogButtonPaddingVertical = 12.0; | ||
| const kColorsColumnSpacing = 3.0; | ||
| final style = Theme.of(context); | ||
| Color selectedColor = currentColor; | ||
|
|
||
| void updated(Color color) { | ||
| updateColor(color); | ||
| Navigator.of(context).pop(); | ||
| } | ||
|
|
||
| showDialog( | ||
| context: context, | ||
| barrierColor: const Color.fromARGB(128, 0, 0, 0), | ||
| builder: (context) { | ||
| return AlertDialog( | ||
| icon: const Icon(Icons.palette), | ||
| title: Text( | ||
| title ?? | ||
| LocaleKeys.settings_appearance_documentSettings_pickColor.tr(), |
There was a problem hiding this comment.
It would be better to subtract a widget to handle the logic instead of putting all of them in a function.
zoli
added a commit
to zoli/AppFlowy
that referenced
this pull request
Jul 14, 2024
* main: (52 commits) chore: improve popup menu color (AppFlowy-IO#5725) fix: ai chat result contains html escape text (AppFlowy-IO#5721) chore: bump version 0.6.4 (AppFlowy-IO#5719) feat: support sign-in and sign-up on Web (AppFlowy-IO#5712) fix: syntax error when generating translation files (AppFlowy-IO#5718) feat: choose cursor/selection color from palette or color picker AppFlowy-IO#5041 (AppFlowy-IO#5677) feat: render ai text message with appflowy_editor (AppFlowy-IO#5682) feat: enable debug logs in internal build (AppFlowy-IO#5713) chore: update yrs and appflowy collab dependencies (AppFlowy-IO#5707) chore: bump version 0.6.3 (AppFlowy-IO#5701) feat: support publish document (AppFlowy-IO#5576) refactor: extract chat plugin to new repo (AppFlowy-IO#5699) fix: take the max value of the keyboard height and the view insets bottom to make the toolbar visible (AppFlowy-IO#5700) chore: use latest macos runner to build the release package (AppFlowy-IO#5686) fix: filter chat page when duplicating (AppFlowy-IO#5676) chore: show ai service error (AppFlowy-IO#5675) feat: sync the created view after duplicating (AppFlowy-IO#5674) chore: disable cloud search (AppFlowy-IO#5663) feat: support moving page to a space (AppFlowy-IO#5665) chore: update German translations (AppFlowy-IO#5640) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Preview
Grabacion.de.pantalla.2024-07-02.a.las.18.54.53.mov
flex_color_pickerdependency.suffixIconparameter to the_ColorSettingTextFieldclass, making it reactive to tap gestures.ColorExtensionon theColorclass to avoid namespace conflicts when converting colors to hexadecimal strings.Addresses (#5041): [FR] Let user pick from a list of predefined colors for selection and cursor colors.
Hand-made tests done on:
PR Checklist