fix: Add retry for admin client sign in for test #5767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoli
added a commit
to zoli/AppFlowy
that referenced
this pull request
Jul 22, 2024
* main: fix: integration test failed (grid row detail page: hide and show hidden fields) (AppFlowy-IO#5781) feat: ai billing (AppFlowy-IO#5741) fix: can not display rows when rows overthan 1000 (AppFlowy-IO#5777) feat: support publish database on web (AppFlowy-IO#5748) feat: publish databse to Web (AppFlowy-IO#5709) chore: update Spanish translations (AppFlowy-IO#5742) chore: update Chinese translations (AppFlowy-IO#5727) fix: Add retry for admin client sign in for test (AppFlowy-IO#5767) chore: update Hebrew translation (AppFlowy-IO#5738) chore: update German translations (AppFlowy-IO#5722) chore: update Russian translations (AppFlowy-IO#5730) chore: update build config (AppFlowy-IO#5759) chore: enable local ai and local ai chat (AppFlowy-IO#5755)
zoli
added a commit
to zoli/AppFlowy
that referenced
this pull request
Jul 22, 2024
* main: fix: integration test failed (grid row detail page: hide and show hidden fields) (AppFlowy-IO#5781) feat: ai billing (AppFlowy-IO#5741) fix: can not display rows when rows overthan 1000 (AppFlowy-IO#5777) feat: support publish database on web (AppFlowy-IO#5748) feat: publish databse to Web (AppFlowy-IO#5709) chore: update Spanish translations (AppFlowy-IO#5742) chore: update Chinese translations (AppFlowy-IO#5727) fix: Add retry for admin client sign in for test (AppFlowy-IO#5767) chore: update Hebrew translation (AppFlowy-IO#5738) chore: update German translations (AppFlowy-IO#5722) chore: update Russian translations (AppFlowy-IO#5730) chore: update build config (AppFlowy-IO#5759) chore: enable local ai and local ai chat (AppFlowy-IO#5755) chore: bump version 0.6.4 (AppFlowy-IO#5744) fix: improve color selector (AppFlowy-IO#5743) fix: reset space relationship when clearing cache (AppFlowy-IO#5737) chore: show plugin state (AppFlowy-IO#5740) chore: download llm files (AppFlowy-IO#5723) feat: optimize the read recent views speed (AppFlowy-IO#5726) chore: fix compile (AppFlowy-IO#5733)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Preview
In AppFlowy-IO/AppFlowy-Cloud#690 , the pg advisory lock has been removed. As a result, if there are concurrent requests to verify a new user's token, only the first request will succeed. In practice, this should rarely happen, and if they do, it's good to throw an error in such case, as concurrent requests like this could be a sign
that there is a bug on the client end.
However, this scenario can happen in test. Cargo execute tests in parallel. Even though unique users and emails are created for most cases, all of them still rely on the admin client to send a request to appflowy cloud in order to generate a sign in url. And all admin client instances share the same user name and email.
This can be resolved if we retry the admin sign in attempt once.
PR Checklist