Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optimize cover title position offset calculation #7568

Merged
merged 2 commits into from
Mar 18, 2025
Merged

fix: optimize cover title position offset calculation #7568

merged 2 commits into from
Mar 18, 2025

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Mar 18, 2025 •
edited
Loading

Feature Preview

  • Use padding instead of positioned in cover title and cover icon
  • Ingore shift+enter in callout/quote and fallback to system behavior

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@LucasXu0 LucasXu0 force-pushed the optimize_title_position branch from 680078b to 8a8d129 Compare March 18, 2025 09:12
@LucasXu0 LucasXu0 merged commit a89dd87 into AppFlowy-IO:main Mar 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v0.8.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LucasXu0