Fix assert by replacing to optional .of(...)
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
themz
changed the title
.of(...)
appflowy
reviewed
Apr 13, 2023
Add long tap behavior to start drag and drop
[FEAT] Add scroll on drag
|
Hey, this PR contains changes unrelated to the assertion fix mentioned in the PR. I will close this and open another PR to resolve the warnings. Feel free to open another issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the logic is a bit broken because
.of(...)is not an optional function, but in code assuming it's.I have updated it to make it optional but did not change any logic behind this.
This is related to #1 as well.
For reference how
.of(..)looks like