Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Mobile toolbar features #159

Closed
hyj1204 opened this issue Jun 1, 2023 · 0 comments · Fixed by #161 or #233
Closed

[FR] Mobile toolbar features #159

hyj1204 opened this issue Jun 1, 2023 · 0 comments · Fixed by #161 or #233
Assignees

Comments

@hyj1204
Copy link
Contributor

hyj1204 commented Jun 1, 2023

Description

The toolbar section in mobile platform is an independent section in Editor package. Since there is no slash menu in the mobile , the toolbar section combined the tool bar features and slash menu features from Desktop.

In mobile, toolbar section mainly has two different parts: ***MobileToolbarItem and its menu widgets.
For example, the textDecorationMobileToolbarItem has 4 formatting features in its menu.
image
Currently, there has two types of MobileToolbarItem: action and withMenu. action is for the feature which implement directly after click the toolbar Item, like code inline. withMenu is for the one needs to open a menu then implement features, like textDecorationMobileToolbarItem

Here is a list of all the toolbar features we plan to implement.

MobileToolbarItem Sub buttons on its Menu PR
textDecoration bold #161
italic #161
underline #161
strikethrough #161
colorDecoration text color picker #233
highlight color picker #233
code None #161
link link input #161
Setting for exist link Need redesign
Same as desktop for now
header heading 1 #161
heading 2 #161
heading 3 #161
list bulleted list #161
numbered list #161
todo list None #161
quote None #161

Impact

Enable editor features in mobile platform.

Additional Context

No response

@hyj1204 hyj1204 self-assigned this Jun 1, 2023
@hyj1204 hyj1204 linked a pull request Jun 8, 2023 that will close this issue
@hyj1204 hyj1204 linked a pull request Jun 21, 2023 that will close this issue
@hyj1204 hyj1204 reopened this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant