-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Text and background color in mobile toolbar #233
Merged
LucasXu0
merged 21 commits into
AppFlowy-IO:main
from
hyj1204:feat/text_color_and_highlight_in_mobile
Jun 25, 2023
Merged
Feat: Text and background color in mobile toolbar #233
LucasXu0
merged 21 commits into
AppFlowy-IO:main
from
hyj1204:feat/text_color_and_highlight_in_mobile
Jun 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #233 +/- ##
==========================================
- Coverage 63.80% 63.66% -0.15%
==========================================
Files 232 239 +7
Lines 9950 10551 +601
==========================================
+ Hits 6349 6717 +368
- Misses 3601 3834 +233
|
Closed
zoli
added a commit
to zoli/appflowy-editor
that referenced
this pull request
Jun 25, 2023
* main: fix: error occurs when applying divider on Mobile (AppFlowy-IO#252) feat: text and background color in mobile toolbar (AppFlowy-IO#233) fix: extend attribute keys shouldn't be sliced (AppFlowy-IO#248) feat: support customizing text attribute key and rendering (AppFlowy-IO#244)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
textAndBackgroundColorMobileToolbarItem
to the toolbar on mobile.ClearColorButton
) is to clear the color(set tonull
).text.and.background.color.mov
Note:
MobileToolbar
. Just set a List ofColorOption
intextColorOptions
or backgroundColorOptions. If it is null, the default color options locate inlib/src/editor/toolbar/mobile/mobile_toolbar.dart
.lib/src/editor/toolbar/utils/color_generators.dart
[FR] Customized color options in color picker for Desktop #234
[FR] UI Improvement for color picker in mobile #235