Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Automatically detect links #328

Closed
Harmon758 opened this issue Jul 19, 2023 · 1 comment
Closed

[FR] Automatically detect links #328

Harmon758 opened this issue Jul 19, 2023 · 1 comment

Comments

@Harmon758
Copy link

Harmon758 commented Jul 19, 2023 •
edited
Loading

Description

Automatically detect links when written or pasted in the editor.

Impact

Anyone who writes or pastes links in the editor.

Additional Context

This is a reiteration of AppFlowy-IO/AppFlowy#1190, which seems to have been resolved by AppFlowy-IO/AppFlowy#851.
However, code from that pull request was commented out in #283 (2b2bce4#diff-ab095d92cb562e31ec1168184ff40ebea568dc4c47def8e3107c3ad9a0f5a009) and removed in #304 (5f136df#diff-ab095d92cb562e31ec1168184ff40ebea568dc4c47def8e3107c3ad9a0f5a009), and links are not automatically detected anymore, so this could be considered a bug/regression.
@Harmon758 Harmon758 mentioned this issue Jul 24, 2023
Closed
Xazin added a commit to Xazin/appflowy-editor that referenced this issue Aug 3, 2023
@Xazin
fix: paste links
761e122 
Closes: AppFlowy-IO#328
@Xazin Xazin mentioned this issue Aug 3, 2023
Closed
Xazin added a commit to Xazin/appflowy-editor that referenced this issue Aug 6, 2023
@Xazin
fix: paste links
69a6161 
Closes: AppFlowy-IO#328
@Harmon758
Copy link
Author

This is fixed now in AppFlowy v0.3.0, with 5df1d3a / #374.

@Harmon758 Harmon758 mentioned this issue Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: paste links Xazin/appflowy-editor
1 participant
@Harmon758