Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Table Icon visible on hover in ReadOnly and causes exception when clicked #717

Closed
zambetpentru opened this issue Feb 16, 2024 · 1 comment

Comments

@zambetpentru
Copy link

Bug Description

When running the Example app and setting Editable = false the table icons are visible and cause an exception when clicked.

How to Reproduce

  1. Start the demo App in Editable:false

  2. Click on the Icon on the table:

image

  1. Error
    image

Expected Behavior

Icon should not be visible in ReadOnly?

Operating System

MacOS

AppFlowy Editor Version(s)

2.3.2

Screenshots

No response

Additional Context

No response

Taverz added a commit to Taverz/appflowy-editor that referenced this issue Mar 4, 2024
…O#717) )

fIx: Table Icon visible on hover in Editable and causes exception when clicked  [Bug]   (issue (AppFlowy-IO#717) )

* fix:  Check visible Widget TableActionHandler when widget.editorState.editable == true

* Update:  lib/src/editor/block_component/table_block_component/table_action_handler.dart
Taverz added a commit to Taverz/appflowy-editor that referenced this issue Mar 5, 2024
…O#717) ) dart format

fIx: Table Icon visible on hover in Editable and causes exception when clicked  [Bug]   (issue (AppFlowy-IO#717) )

* fix:  Check visible Widget TableActionHandler when widget.editorState.editable == true

* Update:  lib/src/editor/block_component/table_block_component/table_action_handler.dart
@Taverz
Copy link
Contributor

Taverz commented Mar 11, 2024

@LucasXu0 Please, сlose this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants