Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Link menu / color overlays persist #77

Closed
Xazin opened this issue Apr 14, 2023 · 1 comment · Fixed by #82
Closed

[Bug] Link menu / color overlays persist #77

Xazin opened this issue Apr 14, 2023 · 1 comment · Fixed by #82
Labels
bug Something isn't working editor features related to the rich-text editor help wanted Extra attention is needed

Comments

@Xazin
Copy link
Collaborator

Xazin commented Apr 14, 2023

Bug Description

If a text node is selected, and you open the Color menu, and then the Link menu, both menus will be open, and when pressing away, only one will close. When pressing on a selection menu item, overlays from other items should be dismissed.

How to Reproduce

  1. Run example application on Windows
  2. Select some text
  3. Press "Link" selection menu item
  4. Press "Color" selection menu item
  5. Press anywhere in the editor
  6. "Color" menu persists and cannot be closed

Expected Behavior

  1. Run example application on Windows
  2. Select some text
  3. Press "Link" selection menu item
  4. Press "Color" selection menu item
  5. "Link" overlay closes automatically
  6. Press anywhere in the editor
  7. "Color" overlay closes automatically

Operating System

Windows

AppFlowy Editor Version(s)

main

Screenshots

Screenshot

image

Additional Context

No response
@LucasXu0 LucasXu0 added bug Something isn't working help wanted Extra attention is needed labels Apr 14, 2023
@Xazin
Copy link
Collaborator Author

Xazin commented Apr 14, 2023

I'm looking into this now

Xazin added a commit to Xazin/appflowy-editor that referenced this issue Apr 14, 2023
@Xazin
fix: one overlay entry for selection menu
fc988f0 
Closes: AppFlowy-IO#77
@Xazin Xazin mentioned this issue Apr 14, 2023
Merged
@annieappflowy annieappflowy added the editor features related to the rich-text editor label Apr 19, 2023
@annieappflowy annieappflowy moved this to Planned in AppFlowy Roadmap Apr 19, 2023
LucasXu0 pushed a commit that referenced this issue Apr 24, 2023
@Xazin
fix: one overlay entry for selection menu (#82)
d4ab376 
Closes: #77
@github-project-automation github-project-automation bot moved this from Planned to Done in AppFlowy Roadmap Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working editor features related to the rich-text editor help wanted Extra attention is needed
Projects
AppFlowy Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: one overlay entry for selection menu Xazin/appflowy-editor
3 participants
@LucasXu0 @annieappflowy @Xazin