Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate the delta encoder #277

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Jul 3, 2023

closes #273

Preview

Code sample

const json = r'''[{"insert":"Hello AppFlowy!"},{"attributes":{"header":1},"insert":"\n"}]''';
final delta = Delta.fromJson(jsonDecode(json));
final document = quillDeltaEncoder.convert(delta);
final editorState = EditorState(document: document);

Documentation

https://github.com/AppFlowy-IO/appflowy-editor/blob/6577d212e80c8765da51ce5addf65a774ea95828/documentation/importing.md

@LucasXu0 LucasXu0 force-pushed the update_delta_converter branch from 6577d21 to a9eb307 Compare July 3, 2023 07:59
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #277 (a9eb307) into main (8bfb37f) will increase coverage by 1.02%.
The diff coverage is 99.13%.

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   62.61%   63.64%   +1.02%     
==========================================
  Files         246      246              
  Lines       10857    10864       +7     
==========================================
+ Hits         6798     6914     +116     
+ Misses       4059     3950     -109     
Impacted Files Coverage Δ
...b/src/plugins/quill_delta/quill_delta_encoder.dart 99.13% <99.13%> (ø)

... and 1 file with indirect coverage changes

@LucasXu0 LucasXu0 merged commit 070ceb3 into AppFlowy-IO:main Jul 3, 2023
LucasXu0 added a commit to MayurSMahajan/appflowy-editor that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Is Importing From Delta Still Possible?
1 participant