Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve keyboard behavior in mobile toolbar #287

Merged
merged 9 commits into from
Jul 12, 2023

Conversation

hyj1204
Copy link
Contributor

@hyj1204 hyj1204 commented Jul 4, 2023

To close #286

  1. When there is no item menu on the screen, the toolbar will show _QuitEditingBtn to close the toolbar and keyboard.
  2. When the item menu is on, the toolbar will show an 'X' icon button to close the menu and pop up keyboard
  3. If the user clicks an action toolbar item(without a menu), it will close the current menu if it is on the screen.
Screen.Recording.2023-07-04.at.4.41.40.PM.mov

@hyj1204 hyj1204 requested a review from LucasXu0 July 4, 2023 21:49
@hyj1204 hyj1204 self-assigned this Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #287 (7ae1da9) into main (2b2bce4) will decrease coverage by 0.15%.
The diff coverage is 26.92%.

@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   68.42%   68.27%   -0.15%     
==========================================
  Files         240      239       -1     
  Lines       10168     9966     -202     
==========================================
- Hits         6957     6804     -153     
+ Misses       3211     3162      -49     
Impacted Files Coverage Δ
...tor_component/service/keyboard_service_widget.dart 85.12% <0.00%> (-4.45%) ⬇️
..._items/color/background_color_options_widgets.dart 62.85% <ø> (-37.15%) ⬇️
...oolbar_items/color/text_color_options_widgets.dart 64.70% <ø> (-35.30%) ⬇️
lib/src/infra/mobile/af_mobile_icon.dart 87.50% <ø> (-12.50%) ⬇️
lib/src/editor/toolbar/mobile/mobile_toolbar.dart 73.40% <31.57%> (-22.85%) ⬇️
...rmat_single_character/format_single_character.dart 96.87% <100.00%> (ø)

... and 40 files with indirect coverage changes

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Jul 7, 2023

@hyj1204 Please check the CI.

@hyj1204 hyj1204 force-pushed the feat/keyboard_in_mobile_toolbar branch from aee55ac to e8b59a6 Compare July 11, 2023 16:05
@hyj1204 hyj1204 requested a review from LucasXu0 July 11, 2023 20:54
@LucasXu0 LucasXu0 changed the title Feat: Improve keyboard behavior in mobile toolbar feat: improve keyboard behavior in mobile toolbar Jul 12, 2023
@LucasXu0 LucasXu0 merged commit 87fd7ed into AppFlowy-IO:main Jul 12, 2023
@hyj1204 hyj1204 deleted the feat/keyboard_in_mobile_toolbar branch July 31, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Improvement on keyboard behavior in mobile toolbar
2 participants