-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve keyboard behavior in mobile toolbar #287
Merged
LucasXu0
merged 9 commits into
AppFlowy-IO:main
from
hyj1204:feat/keyboard_in_mobile_toolbar
Jul 12, 2023
Merged
feat: improve keyboard behavior in mobile toolbar #287
LucasXu0
merged 9 commits into
AppFlowy-IO:main
from
hyj1204:feat/keyboard_in_mobile_toolbar
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
==========================================
- Coverage 68.42% 68.27% -0.15%
==========================================
Files 240 239 -1
Lines 10168 9966 -202
==========================================
- Hits 6957 6804 -153
+ Misses 3211 3162 -49
|
LucasXu0
reviewed
Jul 5, 2023
lib/src/editor/editor_component/service/keyboard_service_widget.dart
Outdated
Show resolved
Hide resolved
lib/src/editor/editor_component/service/keyboard_service_widget.dart
Outdated
Show resolved
Hide resolved
@hyj1204 Please check the CI. |
hyj1204
force-pushed
the
feat/keyboard_in_mobile_toolbar
branch
from
July 11, 2023 16:05
aee55ac
to
e8b59a6
Compare
LucasXu0
changed the title
Feat: Improve keyboard behavior in mobile toolbar
feat: improve keyboard behavior in mobile toolbar
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #286
_QuitEditingBtn
to close the toolbar and keyboard.Screen.Recording.2023-07-04.at.4.41.40.PM.mov