-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix overflow in heading mobile toolbar menu #291
Conversation
instead of showing in 2 lines use wrap widget if screen is too small third heading will be rendered at second line that is more better looking than rendering text in 2 lines |
I am wondering if it would be fine to hide text where the icons themselves are so common that the user wouldn't have a problem interpreting it, on small screens. |
lib/src/editor/toolbar/mobile/toolbar_items/heading_mobile_toolbar_item.dart
Outdated
Show resolved
Hide resolved
@hyj1204 Please check the comments. |
Yes, for the heading part, the icons are easy to understand, I just feel we should try to keep the same UI style rules in all the mobile toolbar item menus. If we change all the buttons in the toolbar item menu to show icons only, I am not sure if all icons are easy to understand, also the icons will be centered in that case I think. |
Codecov Report
@@ Coverage Diff @@
## main #291 +/- ##
==========================================
+ Coverage 68.28% 70.40% +2.12%
==========================================
Files 240 239 -1
Lines 10172 9948 -224
==========================================
+ Hits 6946 7004 +58
+ Misses 3226 2944 -282
|
f346b3d
to
e9d3fe2
Compare
To fix #285
I refactored the UI to make sure it always has three buttons on the heading mobile toolbar menu.
If the width of the screen is too small, the button texts will show in 2 lines