-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import assets from markdown file #316
Import assets from markdown file #316
Conversation
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
==========================================
+ Coverage 72.24% 75.40% +3.16%
==========================================
Files 237 238 +1
Lines 9539 9649 +110
==========================================
+ Hits 6891 7276 +385
+ Misses 2648 2373 -275
|
@LucasXu0 ,please can you review this PR |
lib/src/plugins/markdown/decoder/document_markdown_decoder.dart
Outdated
Show resolved
Hide resolved
lib/src/plugins/markdown/decoder/document_markdown_decoder.dart
Outdated
Show resolved
Hide resolved
@Mukund-Tandon I did some changes.
|
Ok 👍 |
@LucasXu0 , Is there anything else I need to do? |
No, you can integrate the latest version into AppFlowy and continue developing the markdown import feature. |
This PR adds support to detect images from markdown file which are in ![Alt text](path to image) format
It also fixes the error where if a file is there in markdown file it is detected as a url since both have a similar representation in markdown - [Alt tex](url or file path) not if it is a file it is treated as a simple paragraph with text "This is currently not supported : [Alt text](file path)"
Related to AppFlowy-IO/AppFlowy#2981