Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: indent padding from left when rtl #318

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

zoli
Copy link
Contributor

@zoli zoli commented Jul 16, 2023

Also introduced last direction concept.

/cc @LucasXu0 These are changes from what we discussed before in Discord.
I tried to add at least one test for each change that I made, With one exception which I've commented on here.

Also introduced last direction concept.
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #318 (5054f69) into main (0249d41) will increase coverage by 2.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   73.02%   75.42%   +2.39%     
==========================================
  Files         236      236              
  Lines        9477     9481       +4     
==========================================
+ Hits         6921     7151     +230     
+ Misses       2556     2330     -226     
Impacted Files Coverage Δ
...block_component/bulleted_list_block_component.dart 91.89% <ø> (-0.52%) ⬇️
...block_component/numbered_list_block_component.dart 92.20% <ø> (+5.62%) ⬆️
...ent/text_block_component/text_block_component.dart 98.03% <ø> (-0.18%) ⬇️
...ist_block_component/todo_list_block_component.dart 86.07% <ø> (-0.83%) ⬇️
...component/base_component/text_direction_mixin.dart 100.00% <100.00%> (ø)
...onent/service/renderer/block_component_widget.dart 83.78% <100.00%> (+3.13%) ⬆️

... and 23 files with indirect coverage changes

@LucasXu0 LucasXu0 merged commit 3bd7c2a into AppFlowy-IO:main Jul 19, 2023
@zoli zoli deleted the fix/rtl-indent branch July 19, 2023 08:05
@LucasXu0 LucasXu0 mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants