-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete "sentence" shortcut #32
feat: delete "sentence" shortcut #32
Conversation
f17b6cb
to
0a5b3a1
Compare
0a5b3a1
to
7d47401
Compare
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 81.68% 82.65% +0.97%
==========================================
Files 124 124
Lines 7178 7184 +6
==========================================
+ Hits 5863 5938 +75
+ Misses 1315 1246 -69
... and 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hey, @Xazin. Can you add more tests for the missing cover line? |
I will look at it tonight 👍 |
There are some lines of code that don't have test coverage. I think it would be helpful to have test coverage for all of the lines. Would you be willing to work on that? |
Yes for sure. I ended up busy this weekend with another project. But I'm back looking at this, will make things a bit prettier and improve test coverage for all of |
260ed4f
to
2cc9be6
Compare
2cc9be6
to
1b014c2
Compare
@LucasXu0 Ready for review Made some changes to the arrow keys handler file, but the logic is and should be the same. The file should have 98% coverage now, few lines not tested, not worth the effort imo atm. |
test/service/internal_key_event_handlers/arrow_keys_handler_test.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Mathias Mogensen <42929161+Xazin@users.noreply.github.com>
LGTM. |
* feat: delete sentence shortcut Closes: AppFlowy-IO#4 * fix: error in shortcut_event_test.dart * fix: prettify and add missing test * test: improve coverage for arrow_keys_handler.dart * chore: Apply suggestions from code review Co-authored-by: Mathias Mogensen <42929161+Xazin@users.noreply.github.com> --------- Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io>
Closes: #4
Need to check if the commands are properly setup for Linux and Windows!